Pass original error and add url on timeout error #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paed01
approved these changes
Sep 27, 2022
|
Perhaps it is possible to drop the VError dependency all together? |
In 1 month node 18 becomes LTS which supports something similar to VError (chaining using cause), so at that time we will remove VError and bump the major ! |
|
@mgronblad, is this still relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the error message of timeout errors to include the url triggering the timeout. Also adds the original got-error as the cause when throwing a timeout error.
In addition, the error message no longer mentions
ESOCKETTIMEDOUT. I changed this because I think it's misleading, considering that got no longer seems to have that specific error code anywhere (did it ever? Seems likely that it might be a leftover from when we used therequestlibrary). In order to find out where in the request process the timeout occured the got error includes atimingsproperty that reveals this.The change of error message is potentially breaking for code that acts on the error message, but I could only see a handful of instances where this is the case. However, the most important thing to me is that the url that timeouts is revealed in the error somehow. I'm open to discussing the other changes.