Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bundling #11

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Fix/bundling #11

merged 5 commits into from
Nov 12, 2024

Conversation

wisko
Copy link
Contributor

@wisko wisko commented Nov 12, 2024

  • I replaced tsc with tsup for build script, to resolve file extension problem with local file imports.
  • I added support for old commonJS packages, since it was an easy fix.
  • I wrote some block comments, which will make it easier for implementors.
  • I realized we used express types in our final build without having it as a dependency. I added it as an optional peer dependency, which seemed to be the appropriate approach here.

@wisko wisko marked this pull request as ready for review November 12, 2024 13:18
assensamuelsson
assensamuelsson approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@assensamuelsson assensamuelsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@wisko wisko merged commit b2c0250 into main Nov 12, 2024
2 checks passed
@wisko wisko deleted the fix/bundling branch November 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assensamuelsson assensamuelsson assensamuelsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wisko @assensamuelsson