Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not import gcp-metadata rabbithole, if not needed #29

Merged
merged 3 commits into from
Dec 10, 2024
Merged

do not import gcp-metadata rabbithole, if not needed #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff29256
do not import gcp-metadata rabbithole, if not needed
jeldeklint Dec 2, 2024
a2626c2
Add back c8 ignore comments to fix test coverage
MattiasOlla Dec 10, 2024
301deef
Bump version
MattiasOlla Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/gcp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import gcpMetaData from "gcp-metadata";

/**
* Fetches the Google Cloud Platform (GCP) project ID from the GCP metadata server.
*
Expand All @@ -9,7 +7,7 @@ export async function getGcpProjectId(): Promise<string | undefined> {
if (process.env.GCP_PROJECT) {
return process.env.GCP_PROJECT;
}

const gcpMetaData = await import("gcp-metadata");
const isAvailable = await gcpMetaData.isAvailable();
if (!isAvailable) return;

Expand Down
2 changes: 2 additions & 0 deletions lib/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream |
messageKey = "message",
timestamp = () => `,"time": "${new Date().toISOString()}"`,
formatLog,
/* c8 ignore start */
transport = shouldPrettyPrint
? {
target: "pino-pretty",
Expand All @@ -65,6 +66,7 @@ export function logger(options: LoggerOptions = {}, stream?: DestinationStream |
},
}
: undefined,
/* c8 ignore stop */
mixin,
...rest
} = options;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bonniernews/logger",
"version": "0.0.9",
"version": "0.0.10",
"description": "Some simple functions to use Trace Context for correlating logs",
"type": "module",
"main": "./dist/index.cjs",
Expand Down
Loading