Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Commit

Permalink
Allow node 20 (#62)
Browse files Browse the repository at this point in the history
  • Loading branch information
varney authored Dec 21, 2023
1 parent 36a3675 commit eef3338
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 18 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
# The branches below must be a subset of the branches above
branches: [ master ]
schedule:
- cron: '37 12 * * 5'
- cron: "37 12 * * 5"

jobs:
analyze:
Expand All @@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ 'javascript' ]
language: [ "javascript" ]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [ 16.x, 18.x, 20.x ]

steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
**Checklist**

- [ ] Was the code tested in lab?
- [ ] Have you reviewed the code yourself?
- [ ] Are the configs updated?
- [ ] Does the readme need an update?

Write the description and the reason for this PR below ↓
---
## Write the description and the reason for this PR below ↓
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
4 changes: 1 addition & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ function defaultFormatter() {
const transports = [ new PromTransport() ];

if (config.log === "file") {
transports.push(
new winston.transports.File({ filename: logFilename() })
);
transports.push(new winston.transports.File({ filename: logFilename() }));
}

if (config.log === "stdout") {
Expand Down
7 changes: 3 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,15 @@
"Markus Ekholm",
"Jens Carlén"
],
"version": "7.2.0",
"version": "7.3.0",
"engines": {
"node": ">=16 <=18",
"yarn": "please use npm"
"node": ">=16"
},
"scripts": {
"test": "mocha --exit && eslint . --ext .js,.json --cache && depcheck",
"posttest": "eslint --cache .",
"lint": "eslint --cache .",
"format": "prettier **/*.js --write && eslint . --fix",
"format": "prettier {,**/,**/**,**/**/**}*.{js,json,md} --write && eslint . --fix",
"coverage": "c8 npm test",
"check-coverage": "c8 check-coverage"
},
Expand Down
3 changes: 2 additions & 1 deletion test/feature/logging-feature.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ Feature("Logging", () => {
});

Scenario("Strip token from log, calling an endpoint", () => {
const message = "HTTP GET, https://example.com/customer-token/v1/tokens/d589b307-a109-4fd1-b621-cc4d5d8f1f32, params: {\"something\": \"param\"}";
const message =
'HTTP GET, https://example.com/customer-token/v1/tokens/d589b307-a109-4fd1-b621-cc4d5d8f1f32, params: {"something": "param"}';

When("logging a message with a URL containing tokens", () => {
logger.debug(message);
Expand Down

0 comments on commit eef3338

Please sign in to comment.