-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt for new multi-threaded cursive capabilities #41
base: master
Are you sure you want to change the base?
Conversation
It is not always useful to always select some item (i.e. first by sorting order, by the way it is not even how it works natively since sort_by() applied after, and you need to call set_selected_item(0) for this). Consider csysdig, by default when you did not press anything it stick to the first item by sort order, and only if you select something (Up/Down) then it will stick to this item in the table. And this behaviour is better, since if you did not focus any item you want to look at the items sorted by the sort order. And I also made the Home button to cancel this selection.
In [1] cursive now requires Send + Sync, and the reason for this is: The View now requires Send + Sync, to allow accessing or moving views between threads. This prevents using Rc/RefCell, and may require using Arc/Mutex instead. This should eventually open the way for more multi-threaded processing of the view tree. [1]: gyscos/cursive@f1f25b1
This PR passes Would be nice to have it as version If so, it would allow
and an updated
EDIT: Note however that I haven't tried to run the program(s) to see if it works correctly. It just builds ok, that's all I know :) |
Note: this includes #40
In 1 cursive now requires Send + Sync, and the reason for this is: