Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review reported Tasks #42

Merged
merged 27 commits into from
May 2, 2024
Merged

Conversation

StackSurfer
Copy link
Contributor

@StackSurfer StackSurfer commented Nov 26, 2023

Description

Issue 1: Missing Task Creator Information

  • The "Reported Tasks" section should have an additional column/field displaying the creator of each reported task.

Issue 2: Report Details Page - Missing & Incorrect Information

  • The report details page should display all essential report details. (Reported By, Reason, Comment, Reported At, and Creator of the task)

    • Multiple-Choice-Question
    • Coding-Challenge
    • Question
    • Matching
  • Locales for added essential report details

  • The "Options" section should only display the original quiz answer options without any additional text.

    • Multiple-Choice-Question
    • Coding-Challenge
    • Question -> have not added a component because this is not available yet
    • Matching
  • Introduce new action buttons as described above. ("Delete Task", "Adjust Task", "Ban Creator", and "Ban Reporter".)

  • Locales for new Buttons

Issue 3: Report Archiving and Revisiting

  • Processed reports should be archived and viewable in a greyed-out format.
  • Introduce a filter option for viewing fresh reports and all reports (including archived ones).

Problems with solving Issue 3 in the Frontend

After resolving a reported task, this task is no longer returned from getReportetTaskList(). It would be beneficial if these tasks still appeared in the list but with an additional key indicating their report state. Additionally, it would be useful to incorporate a query parameter in the get call, allowing for the retrieval of either 'open', 'resolved', or 'all' reported tasks.

Be careful if testing the Buttons in the Dev Environment as they are fully functional

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Translation updates (fix/improve or add new translations)

Fixes Bootstrap-Academy/Bootstrap-Academy#34

My Bootstrap Academy username:

@StackSurfer StackSurfer marked this pull request as ready for review December 9, 2023 16:43
@StackSurfer
Copy link
Contributor Author

I just tried to report "coding-challenges". But theres 1. no report button and 2. I get responses of "not authorized" || "permission_denied" when reporting it in SwaggerUI even tough I'm authorized in with bearer. (tried it with admin & normal-user, before solving and after)

@Defelo
Copy link
Member

Defelo commented Dec 9, 2023

Have you solved the subtask before trying to report it? Currently this is a requirement, but we might have to rethink that later

@StackSurfer
Copy link
Contributor Author

Have you solved the subtask before trying to report it? Currently this is a requirement, but we might have to rethink that later

Yes I did solve it with 2 accounts and tried to report it but that did not work

@Defelo
Copy link
Member

Defelo commented Dec 9, 2023

Did you rate the subtask after solving it? Because at the moment you can only rate or report it, but not both (probably also needs to be changed later)

@StackSurfer
Copy link
Contributor Author

Did you rate the subtask after solving it? Because at the moment you can only rate or report it, but not both (probably also needs to be changed later)

I have not found any ability to rate or report a coding-challenge with the current UI

@Defelo
Copy link
Member

Defelo commented Dec 9, 2023

Ok, then it is probably not implemented yet. Could you post the exact http request you are sending to the backend to report the coding challenge (you can just copy paste the curl command from swagger)? And also the response please?

@StackSurfer
Copy link
Contributor Author

Yes sure!
request:
{ "POST": { "scheme": "https", "host": "api-test.bootstrap.academy", "filename": "/challenges/subtask_reports", "remote": { "Address": "[2a06:98c1:3121::3]:443" } } }
Body:
{ "comment": "test report coding-challenge", "reason": "ABUSE", "subtask_id": "617284ef-cb4a-456c-86b6-c7e422801812", "task_id": "55e96838-2ac6-419a-9d26-449ba4638840" }
response:
{ "error": "permission_denied" }

@StackSurfer
Copy link
Contributor Author

@Defelo Are there new Code-style guidelines because that check failed?

@Defelo
Copy link
Member

Defelo commented Dec 28, 2023

Yes, we recently added eslint to enforce a consistent code style (#51). You should be able to fix most (if not all) of these errors with eslint --fix --ext .js,.vue,.ts .

@Defelo Defelo self-requested a review May 2, 2024 14:40
@Defelo Defelo self-assigned this May 2, 2024
Copy link

github-actions bot commented May 2, 2024

Preview deployed to https://c42c7158.academy-admin-preview.pages.dev (total size: 3.9M)

@Defelo Defelo merged commit a156ea1 into Bootstrap-Academy:develop May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reviewing reported Tasks in the admin dashboard
2 participants