Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor attributes code #641

Merged
merged 22 commits into from
Nov 3, 2024
Merged

Refactor attributes code #641

merged 22 commits into from
Nov 3, 2024

Conversation

BradyAJohnston
Copy link
Owner

@BradyAJohnston BradyAJohnston commented Oct 30, 2024

Refactors the attribute code to better abstract it and make more generalised.

Movement towards having the numpy / blender interface being a separate module that can be used in other projects.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 81.68498% with 100 lines in your changes missing coverage. Please review.

Project coverage is 73.89%. Comparing base (bb35110) to head (b5af79a).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
molecularnodes/blender/bpyd/attribute.py 76.77% 36 Missing ⚠️
molecularnodes/blender/bpyd/object.py 81.10% 24 Missing ⚠️
molecularnodes/blender/bpyd/nodes.py 82.85% 18 Missing ⚠️
molecularnodes/blender/bpyd/collection.py 70.58% 5 Missing ⚠️
molecularnodes/entities/trajectory/trajectory.py 80.00% 5 Missing ⚠️
molecularnodes/blender/nodes.py 69.23% 4 Missing ⚠️
molecularnodes/entities/molecule/molecule.py 85.71% 2 Missing ⚠️
molecularnodes/entities/trajectory/ui.py 0.00% 2 Missing ⚠️
molecularnodes/ui/panel.py 33.33% 2 Missing ⚠️
molecularnodes/blender/utils.py 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #641      +/-   ##
==========================================
+ Coverage   71.73%   73.89%   +2.15%     
==========================================
  Files          50       54       +4     
  Lines        4143     4271     +128     
==========================================
+ Hits         2972     3156     +184     
+ Misses       1171     1115      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyAJohnston BradyAJohnston merged commit 4d792c5 into main Nov 3, 2024
5 checks passed
@BradyAJohnston BradyAJohnston deleted the refactor-attributes branch November 3, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant