-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-2210] Add support for Meta Install Referrer #1160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
============================================
+ Coverage 38.26% 38.46% +0.19%
Complexity 685 685
============================================
Files 59 58 -1
Lines 6220 6193 -27
Branches 933 928 -5
============================================
+ Hits 2380 2382 +2
+ Misses 3394 3365 -29
Partials 446 446 ☔ View full report in Codecov by Sentry. |
jf-branch
reviewed
Jan 18, 2024
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
Branch-SDK/src/main/java/io/branch/coroutines/InstallReferrers.kt
Outdated
Show resolved
Hide resolved
gdeluna-branch
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2210 -- Support Meta's Install Referrer to track EVC
Description
Meta has their own install referrer that tracked ad clicks and views in their apps. We want to fetch and pass this through similar to the other install referrers like Google Play, Samsung, etc.
To handle this, we fetch the install referrer from the Facebook or Instagram content provider. Then we have specific logic on how to handle it based on if it is a click through or view through. There is also always an accompanying Google Play Install Referrer so we have to dedupe them based on if they have the same click timestamp.
Testing Instructions
Or verify through unit tests.
Risk Assessment [
MEDIUM
]Adds new code to the install referrer code which could impact session initialization and install tracking.
Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.