Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2210] Add support for Meta Install Referrer #1160

Merged
merged 15 commits into from
Mar 6, 2024
Merged

Conversation

nsingh-branch
Copy link
Contributor

Reference

SDK-2210 -- Support Meta's Install Referrer to track EVC

Description

Meta has their own install referrer that tracked ad clicks and views in their apps. We want to fetch and pass this through similar to the other install referrers like Google Play, Samsung, etc.
To handle this, we fetch the install referrer from the Facebook or Instagram content provider. Then we have specific logic on how to handle it based on if it is a click through or view through. There is also always an accompanying Google Play Install Referrer so we have to dedupe them based on if they have the same click timestamp.

Testing Instructions

  • Add the FB SDK to an test app
  • Setup a FB ad for the app and click it on a device
  • Install the app and observe the proper install referrer data being passed through
    Or verify through unit tests.

Risk Assessment [MEDIUM]

Adds new code to the install referrer code which could impact session initialization and install tracking.

  • I, the PR creator, have tested — integration, unit, or otherwise — this code.

Reviewer Checklist (To be checked off by the reviewer only)

  • JIRA Ticket is referenced in PR title.
  • Correctness & Style
    • Conforms to AOSP Style Guides
    • Mission critical pieces are documented in code and out of code as needed.
  • Unit Tests reviewed and test issue sufficiently.
  • Functionality was reviewed in QA independently by another engineer on the team.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 38.46%. Comparing base (9e4a699) to head (1ef7dc5).

Files Patch % Lines
...h-SDK/src/main/java/io/branch/referral/Branch.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1160      +/-   ##
============================================
+ Coverage     38.26%   38.46%   +0.19%     
  Complexity      685      685              
============================================
  Files            59       58       -1     
  Lines          6220     6193      -27     
  Branches        933      928       -5     
============================================
+ Hits           2380     2382       +2     
+ Misses         3394     3365      -29     
  Partials        446      446              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsingh-branch nsingh-branch merged commit 91af2e6 into master Mar 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants