Skip to content

Commit

Permalink
Merge pull request #7 from BranchMetrics/staging
Browse files Browse the repository at this point in the history
Fix for missing idfa
  • Loading branch information
echo-branch authored Dec 14, 2019
2 parents 699f047 + 78ce91d commit 0b6afa4
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
3 changes: 3 additions & 0 deletions Branch.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -1184,6 +1184,7 @@
CODE_SIGN_IDENTITY = "Mac Developer";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = "";
MARKETING_VERSION = 1.2.1;
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
PROVISIONING_PROFILE_SPECIFIER = "";
};
Expand All @@ -1195,6 +1196,7 @@
CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = "";
MARKETING_VERSION = 1.2.1;
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
PROVISIONING_PROFILE_SPECIFIER = "";
};
Expand Down Expand Up @@ -1298,6 +1300,7 @@
CODE_SIGN_IDENTITY = "";
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = "";
MARKETING_VERSION = 1.2.1;
PRODUCT_BUNDLE_IDENTIFIER = io.branch.sdk.mac;
PROVISIONING_PROFILE_SPECIFIER = "";
};
Expand Down
12 changes: 3 additions & 9 deletions Branch/BNCDevice.m
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,9 @@ - (NSString *)vendorID {

#endif

- (NSString*) hardwareID {
NSString*s;
- (NSString *)hardwareID {
// INTENG-8458 server only wants hardware id and hardware id type for idfa and idfv.
NSString *s = nil;
s = [self advertisingID];
if (s) {
_hardwareIDType = @"idfa";
Expand All @@ -298,13 +299,6 @@ - (NSString*) hardwareID {
_hardwareIDType = @"vendor_id";
return s;
}
s = [self netAddress];
if (s) {
_hardwareIDType = @"mac_address";
return s;
}
s = [[NSUUID UUID] UUIDString];
_hardwareIDType = @"random";
return s;
}

Expand Down
2 changes: 1 addition & 1 deletion Branch/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.2.0</string>
<string>$(MARKETING_VERSION)</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>NSHumanReadableCopyright</key>
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Branch Mac SDK Change Log

## v1.2.1 - December 13, 2019
* Fix crash when idfa is not available

## v1.2.0 - October 7, 2019
* Add user agent
* Attribution fixes
Expand Down
Binary file modified Frameworks/macOS/Branch.framework/Versions/A/Branch
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<plist version="1.0">
<dict>
<key>BuildMachineOSBuild</key>
<string>18G95</string>
<string>18G1012</string>
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleExecutable</key>
Expand All @@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.2.0</string>
<string>1.2.1</string>
<key>CFBundleSupportedPlatforms</key>
<array>
<string>MacOSX</string>
Expand All @@ -27,17 +27,17 @@
<key>DTCompiler</key>
<string>com.apple.compilers.llvm.clang.1_0</string>
<key>DTPlatformBuild</key>
<string>11A1027</string>
<string>11C29</string>
<key>DTPlatformVersion</key>
<string>GM</string>
<key>DTSDKBuild</key>
<string>19A547</string>
<string>19B90</string>
<key>DTSDKName</key>
<string>macosx10.15</string>
<key>DTXcode</key>
<string>1110</string>
<string>1130</string>
<key>DTXcodeBuild</key>
<string>11A1027</string>
<string>11C29</string>
<key>LSMinimumSystemVersion</key>
<string>10.10</string>
<key>NSHumanReadableCopyright</key>
Expand Down

0 comments on commit 0b6afa4

Please sign in to comment.