Onclick on cells #21
Merged
Onclick on cells #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the latest Kotlin and Compose versions
FIX: Table isn't quite visible when user changes to dark theme
…ps that use the library
|
as you said in my last PR |
|
Great!
…On Thu, Aug 22, 2024, 4:47 PM Breens Robert ***@***.***> wrote:
Merged #21
<#21> into
develop.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFPM4XKUWUWBZMDXYIV7TLZSYB2TAVCNFSM6AAAAABKTIC22WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE3TSOJXGI2DMNA>
.
You are receiving this because you authored the thread.Message ID:
<Breens-Mbaka/Jetpack-Compose-Tables/pull/21/issue_event/13979972464@
github.com>
|
|
Awesome, thank you so much!
…On Thu, Aug 22, 2024, 4:51 PM Breens Robert ***@***.***> wrote:
LGTM I'll proceed to merge it to the master branch. Thank you for your
contribution @gwabstech <https://github.com/gwabstech>
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFPM4STQ3JN6G7SCV4UCNLZSYCHVAVCNFSM6AAAAABKTIC22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGEYDEMJVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
How is the protest in Kenya hope it's getting better
On Thu, Aug 22, 2024, 4:59 PM Abubakar Abdullahi Gwabare <
***@***.***> wrote:
… Awesome, thank you so much!
On Thu, Aug 22, 2024, 4:51 PM Breens Robert ***@***.***>
wrote:
> LGTM I'll proceed to merge it to the master branch. Thank you for your
> contribution @gwabstech <https://github.com/gwabstech>
>
> —
> Reply to this email directly, view it on GitHub
> <#21 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ARFPM4STQ3JN6G7SCV4UCNLZSYCHVAVCNFSM6AAAAABKTIC22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGEYDEMJVGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Hi @gwabstech when I go to the second row the index starts again at zero instead of continuing to 5,6,7. I think that's how it should work. Check the video recording below and revert Screen.Recording.2024-08-22.at.19.00.33.mov |
|
Yes sure but am working on a specific cell click so that each cell can be
clicked indepently. For now that's the default case it start from zero when
you go to second row
…On Thu, Aug 22, 2024, 5:02 PM Breens Robert ***@***.***> wrote:
Hi @gwabstech <https://github.com/gwabstech> when I go to the second row
the index starts again at zero instead of continuing to 5,6,7. I think
that's how it should work right ? Check video recording below
https://github.com/user-attachments/assets/44a20f3f-6cb2-4dd2-932e-3f0ee7f03704
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFPM4WYUQIX6DOILYMJ2D3ZSYDSLAVCNFSM6AAAAABKTIC22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGEZDQMJZHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Okay that's fine, but how will someone know they are clicking on a cell in the second row and not the first row ? |
|
Great point let me review and get back to you tonight
…On Thu, Aug 22, 2024, 5:06 PM Breens Robert ***@***.***> wrote:
Okay that's fine, but how will someone know they are clicking on a cell in
the second row and not the first row ?
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARFPM4TZJILWRCIOV4GGNOLZSYECBAVCNFSM6AAAAABKTIC22WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGEZTMNJXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Aug 23, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added onclick on the cells each sell created is clickable kindly review and if needed any changes or fixing let me know