Build

ASC - non-case sensitive exclude checking, increase debugging (#568) #467

Triggered via push October 10, 2023 16:54

BrettMayson

pushed 23f5c7e

main

Status Success

Total duration 21m 48s

Artifacts 2

This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

build.yaml

on: push

Matrix: build

Release

Matrix: mods

Annotations

1 error and 28 warnings

the borrowed expression implements the required traits: bin/src/modules/rapifier.rs#L47

error: the borrowed expression implements the required traits --> bin/src/modules/rapifier.rs:47:51 | 47 | for entry in ctx.workspace().join(&addon.folder())?.walk_dir()? { | ^^^^^^^^^^^^^^^ help: change this to: `addon.folder()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args note: the lint level is defined here --> bin/src/lib.rs:1:9 | 1 | #![deny(clippy::all, clippy::nursery)] | ^^^^^^^^^^^ = note: `#[deny(clippy::needless_borrows_for_generic_args)]` implied by `#[deny(clippy::all)]`

method `add_exclude` is never used: bin/src/modules/asc.rs#L254

warning: method `add_exclude` is never used --> bin/src/modules/asc.rs:254:12 | 228 | impl ASCConfig { | -------------- method in this implementation ... 254 | pub fn add_exclude(&mut self, dir: &str) { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

unused variable: `exclude`: bin/src/modules/asc.rs#L171

warning: unused variable: `exclude` --> bin/src/modules/asc.rs:171:13 | 171 | for exclude in ctx.config().asc().exclude() { | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exclude` | = note: `#[warn(unused_variables)]` on by default

this match arm has an identical body to another arm: libs/preprocessor/src/processor/directives.rs#L94

warning: this match arm has an identical body to another arm --> libs/preprocessor/src/processor/directives.rs:94:13 | 94 | (_, false) => { | ^--------- | | | _____________help: try merging the arm patterns: `(_, false) | ("pragma", _)` | | 95 | | self.skip_to_after_newline(stream, None); 96 | | Ok(()) 97 | | } | |_____________^ | = help: or try changing either arm body note: other arm here --> libs/preprocessor/src/processor/directives.rs:86:13 | 86 | / ("pragma", _) => { 87 | | // TODO: hemtt pragma 88 | | self.skip_to_after_newline(stream, None); 89 | | Ok(()) 90 | | } | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms note: the lint level is defined here --> libs/preprocessor/src/lib.rs:2:9 | 2 | #![warn(clippy::pedantic)] | ^^^^^^^^^^^^^^^^ = note: `#[warn(clippy::match_same_arms)]` implied by `#[warn(clippy::pedantic)]`

fields `declarations` and `usage` are never read: libs/common/src/reporting/processed.rs#L25

warning: fields `declarations` and `usage` are never read --> libs/common/src/reporting/processed.rs:25:5 | 13 | pub struct Processed { | --------- fields in this struct ... 25 | declarations: HashMap<Position, Position>, | ^^^^^^^^^^^^ ... 29 | usage: HashMap<Position, Vec<Position>>, | ^^^^^ | = note: `Processed` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

method `add_exclude` is never used: bin/src/modules/asc.rs#L254