Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: Inspector #780

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

sqf: Inspector #780

wants to merge 27 commits into from

Conversation

PabstMirror
Copy link
Collaborator

  • Type checking
  • Var Usage (Undefined, Not Private, Shadowing and Unused)

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 82.31293% with 260 lines in your changes missing coverage. Please review.

Project coverage is 68.6%. Comparing base (b1df2c0) to head (188f5eb).

Files with missing lines Patch % Lines
libs/sqf/src/analyze/inspector/commands.rs 79.6% 66 Missing ⚠️
...bs/sqf/src/analyze/inspector/external_functions.rs 72.0% 43 Missing ⚠️
libs/sqf/src/analyze/inspector/game_value.rs 82.1% 30 Missing ⚠️
libs/sqf/src/analyze/lints/s14_unused.rs 78.6% 22 Missing ⚠️
libs/sqf/src/analyze/inspector/mod.rs 93.5% 21 Missing ⚠️
libs/sqf/src/analyze/lints/s13_undefined.rs 80.7% 20 Missing ⚠️
libs/sqf/src/analyze/lints/s15_shadowed.rs 78.9% 20 Missing ⚠️
libs/sqf/src/analyze/lints/s12_invalid_args.rs 79.7% 19 Missing ⚠️
libs/sqf/src/analyze/lints/s16_not_private.rs 79.7% 19 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/analyze/mod.rs 93.8% <ø> (ø)
libs/sqf/src/lib.rs 51.7% <100.0%> (+2.3%) ⬆️
libs/sqf/src/parser/mod.rs 100.0% <100.0%> (ø)
libs/sqf/src/analyze/lints/s12_invalid_args.rs 79.7% <79.7%> (ø)
libs/sqf/src/analyze/lints/s16_not_private.rs 79.7% <79.7%> (ø)
libs/sqf/src/analyze/lints/s13_undefined.rs 80.7% <80.7%> (ø)
libs/sqf/src/analyze/lints/s15_shadowed.rs 78.9% <78.9%> (ø)
libs/sqf/src/analyze/inspector/mod.rs 93.5% <93.5%> (ø)
libs/sqf/src/analyze/lints/s14_unused.rs 78.6% <78.6%> (ø)
libs/sqf/src/analyze/inspector/game_value.rs 82.1% <82.1%> (ø)
... and 2 more

... and 6 files with indirect coverage changes

@BrettMayson
Copy link
Owner

I was also working on something like this, and using the type information from the wiki.

I'm not a fan of it being one big piece that is a single lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants