Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: invalid comparisons #801

Merged
merged 2 commits into from
Oct 18, 2024
Merged

sqf: invalid comparisons #801

merged 2 commits into from
Oct 18, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Oct 18, 2024

There may still be false positives, but I didn't find any with the few repos I have locally
There may be false negatives, but I think that's ok

Copy link
Collaborator

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't see any hits on my repos

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 71.32616% with 80 lines in your changes missing coverage. Please review.

Project coverage is 68.2%. Comparing base (015cbf5) to head (613f24e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/sqf/src/analyze/lints/s21_invalid_comparisons.rs 71.2% 80 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/analyze/lints/s18_in_vehicle_check.rs 73.3% <100.0%> (ø)
...s/sqf/src/analyze/lints/s21_invalid_comparisons.rs 71.2% <71.2%> (ø)

... and 3 files with indirect coverage changes

@BrettMayson BrettMayson merged commit c4d4960 into main Oct 18, 2024
32 of 33 checks passed
@BrettMayson BrettMayson deleted the comparisons branch October 18, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants