Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: optimize _this call #802

Merged
merged 6 commits into from
Oct 18, 2024
Merged

sqf: optimize _this call #802

merged 6 commits into from
Oct 18, 2024

Conversation

BrettMayson
Copy link
Owner

  • Optimizes _this call to just call
  • Off by default lint

@BrettMayson BrettMayson merged commit a148b53 into main Oct 18, 2024
12 of 20 checks passed
@BrettMayson BrettMayson deleted the this_call branch October 18, 2024 02:08
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 69.30693% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.2%. Comparing base (4d93c00) to head (e33cdc5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/analyze/lints/s22_this_call.rs 74.1% 24 Missing ⚠️
libs/sqf/src/compiler/optimizer/mod.rs 12.5% 7 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/compiler/optimizer/mod.rs 78.8% <12.5%> (-1.9%) ⬇️
libs/sqf/src/analyze/lints/s22_this_call.rs 74.1% <74.1%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants