Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use insta for snapshots #808

Merged
merged 3 commits into from
Oct 20, 2024
Merged

use insta for snapshots #808

merged 3 commits into from
Oct 20, 2024

Conversation

BrettMayson
Copy link
Owner

I'm curious about your thoughts on this

The tool is nice to review without needing to wipe out the file to have it write the changes like we currently do

@PabstMirror
Copy link
Collaborator

maybe 2 negatives
is that any changes to data structure could trigger many things to fail (I think?)
and having to remember to use the cli thing
but overall it seems fine and I do see the benefit

@BrettMayson BrettMayson merged commit 89056c4 into main Oct 20, 2024
34 of 37 checks passed
@BrettMayson BrettMayson deleted the test_rework branch October 20, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants