Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqf: remove asc #809

Merged
merged 2 commits into from
Oct 20, 2024
Merged

sqf: remove asc #809

merged 2 commits into from
Oct 20, 2024

Conversation

BrettMayson
Copy link
Owner

@BrettMayson BrettMayson commented Oct 20, 2024

HEMTT's is faster and superior now, simplifies things to remove it

Not gonna lie part of this is because I want to use cargo-mutants, but I can't with RustEmbed

I could say it reduces the executable size by 7 or 20 megabytes but no one cares about file size

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.8%. Comparing base (89056c4) to head (1985f1c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/modules/sqf.rs 60.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/src/commands/build.rs 93.5% <100.0%> (+2.1%) ⬆️
bin/src/commands/dev.rs 87.7% <100.0%> (+0.7%) ⬆️
bin/src/error.rs 0.0% <ø> (ø)
bin/src/modules/mod.rs 100.0% <ø> (ø)
libs/sqf/src/compiler/serializer/mod.rs 46.2% <ø> (ø)
bin/src/modules/sqf.rs 59.6% <60.0%> (-0.7%) ⬇️

... and 1 file with indirect coverage changes

@BrettMayson BrettMayson merged commit 1a0f679 into main Oct 20, 2024
22 of 23 checks passed
@BrettMayson BrettMayson deleted the remove_asc branch October 20, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants