Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

progress bar #811

Merged
merged 3 commits into from
Oct 22, 2024
Merged

progress bar #811

merged 3 commits into from
Oct 22, 2024

Conversation

BrettMayson
Copy link
Owner

Doesn't show up in CI

Screencast.From.2024-10-21.18-23-46.webm

@BrettMayson BrettMayson marked this pull request as ready for review October 22, 2024 00:26
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.1%. Comparing base (c3be35a) to head (7fba995).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/src/progress.rs 80.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/src/lib.rs 75.6% <ø> (ø)
bin/src/modules/archive.rs 95.6% <100.0%> (+0.7%) ⬆️
bin/src/modules/files.rs 97.9% <100.0%> (+0.3%) ⬆️
bin/src/modules/pbo.rs 80.0% <100.0%> (+0.5%) ⬆️
bin/src/modules/rapifier.rs 76.4% <100.0%> (+0.5%) ⬆️
bin/src/modules/sqf.rs 58.8% <100.0%> (+0.8%) ⬆️
bin/src/progress.rs 80.0% <80.0%> (ø)

@PabstMirror
Copy link
Collaborator

PabstMirror commented Oct 22, 2024

not a big deal but 79/43 doesn't make sense
(might be counting subconfigs vs addons)
image

@BrettMayson
Copy link
Owner Author

Ah yup

@BrettMayson BrettMayson merged commit d23d6e6 into main Oct 22, 2024
34 of 37 checks passed
@BrettMayson BrettMayson deleted the progress branch October 22, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants