Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stringtables: add trailing newline, trim for comparisions #826

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

BrettMayson
Copy link
Owner

Fixes #825

@BrettMayson BrettMayson merged commit f5ddcd5 into main Nov 9, 2024
18 of 20 checks passed
@BrettMayson BrettMayson deleted the stringtable_trim branch November 9, 2024 01:30
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.1%. Comparing base (ab357f8) to head (e2bd90b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
libs/stringtable/src/lib.rs 0.0% 6 Missing ⚠️
libs/stringtable/src/analyze/lints/01_sorted.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/stringtable/src/analyze/lints/01_sorted.rs 27.4% <0.0%> (ø)
libs/stringtable/src/lib.rs 22.5% <0.0%> (-3.4%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty line at the end of stringtable.xml prints warning
1 participant