Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preprocessor: detect circular includes #916

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

BrettMayson
Copy link
Owner

Fixes #914

I can see some rare cases where this is allowed with #if and other checks, but I think that's rare enough that this PR is fine instead of crashing

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.5%. Comparing base (7eadf0f) to head (fc5e970).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...bs/preprocessor/src/codes/pe29_circular_include.rs 97.5% 1 Missing ⚠️
libs/preprocessor/src/processor/directives.rs 85.7% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/preprocessor/src/processor/mod.rs 89.7% <100.0%> (+0.3%) ⬆️
...bs/preprocessor/src/codes/pe29_circular_include.rs 97.5% <97.5%> (ø)
libs/preprocessor/src/processor/directives.rs 91.2% <85.7%> (-0.1%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BrettMayson BrettMayson merged commit ec8a763 into main Mar 11, 2025
36 of 37 checks passed
@BrettMayson BrettMayson deleted the circular_include branch March 11, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Detect circular include
1 participant