Improve support to .NET Standard and .NET Framework #3507
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates Failed
(1 hotspot with Code Duplication)
(1 file with Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 rule in this hotspot | 9.39 → 9.10 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 advisory rule | 9.39 → 9.10 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
lillo42
requested review from
iancooper,
holytshirt,
DevJonny and
preardon
as code owners
There was a problem hiding this comment.
Gates Failed
(1 hotspot with Code Duplication)
(1 file with Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 rule in this hotspot | 9.39 → 9.10 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 advisory rule | 9.39 → 9.10 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
Gates Failed
(1 hotspot with Code Duplication)
(1 file with Code Duplication)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Prevent hotspot decline | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 rule in this hotspot | 9.39 → 9.10 | Suppress |
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| MySqlOutbox.cs | 1 advisory rule | 9.39 → 9.10 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| MySqlOutbox.cs | 9.39 → 10.00 | Code Duplication |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
| @@ -159,14 +159,22 @@ protected override async Task<T> ReadFromStoreAsync<T>( | |||
|
|
|||
| if (connection.State != ConnectionState.Open) | |||
| await connection.OpenAsync(cancellationToken); | |||
| #if NETSTANDARD2_0 | |||
There was a problem hiding this comment.
✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure
|
@lillo42 Let me know if understand the issue right - build constraints - if so happy to merge |
|
Hey @iancooper
Depending, on About the Microsoft.NETFramework.ReferenceAssemblies I've added it to allow build .NET Framework on non-Windows machine, it's used only for MS SQL packages |
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| MySqlOutbox.cs | 9.39 → 10.00 | Code Duplication |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| MySqlOutbox.cs | 9.39 → 10.00 | Code Duplication |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Passed
See analysis details in CodeScene
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| MySqlOutbox.cs | 9.39 → 10.00 | Code Duplication |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Many projects can have support for .NET Standard and we haven't added support to it.
I've created 3 variables: