Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIM-4113 - add constants needed for super quick eval #254

Merged
merged 2 commits into from
Feb 12, 2025
Merged

NIM-4113 - add constants needed for super quick eval #254

merged 2 commits into from
Feb 12, 2025

Conversation

TristanDevos
Copy link
Contributor

@TristanDevos TristanDevos requested a review from a team as a code owner February 12, 2025 20:49
@TristanDevos TristanDevos requested review from NicholasFlorian, mariellemanlulu, EvanLemieux and amauryperez and removed request for a team February 12, 2025 20:49
TristanDevos
TristanDevos commented Feb 12, 2025
View reviewed changes
index.js Outdated
@@ -80,6 +81,7 @@ export const Rels = {
explicitEvaluation: 'https://activities.api.brightspace.com/rels/explicit-evaluation',
feedback: 'https://activities.api.brightspace.com/rels/feedback',
feedbackAttachments: 'https://activities.api.brightspace.com/rels/attachments',
iteratorEvaluationApplication: 'https://api.brightspace.com/rels/iterator-evaluation-application',
Copy link
Contributor Author

@TristanDevos TristanDevos Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amauryperez I just realized this doesn't have the activities subdomain - do we want to add that here and on the API side?

If not, I'll move this up out of the activities domain

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it

@TristanDevos TristanDevos merged commit 62b4877 into master Feb 12, 2025
2 checks passed
@TristanDevos TristanDevos deleted the tdevos/NIM-4113/update-constants-for-super-quick-eval branch February 12, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eKoopmans eKoopmans eKoopmans approved these changes

@amauryperez amauryperez amauryperez approved these changes

@NicholasFlorian NicholasFlorian Awaiting requested review from NicholasFlorian NicholasFlorian is a code owner automatically assigned from Brightspace/voyager

@mariellemanlulu mariellemanlulu Awaiting requested review from mariellemanlulu mariellemanlulu is a code owner automatically assigned from Brightspace/voyager

@EvanLemieux EvanLemieux Awaiting requested review from EvanLemieux EvanLemieux is a code owner automatically assigned from Brightspace/voyager

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TristanDevos @eKoopmans @amauryperez