Merge pull request #217 from BritishGeologicalSurvey/215-make-oracled…

…bhelperget_sqlalchemy_connection_string-use-oracle+oracledb-instead-of-oracle 215 make oracledbhelperget sqlalchemy connection string use oracle+oracledb instead of oracle
BritishGeologicalSurvey · Nov 26, 2024 · e466256 · e466256
2 parents fd9278e + 6ac4ecd
commit e466256
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/etlhelper/db_helpers/oracle.py b/etlhelper/db_helpers/oracle.py
@@ -66,5 +66,5 @@ def get_sqlalchemy_connection_string(self, db_params, password_variable):
         Returns connection string for SQLAlchemy engine.
         """
         password = self.get_password(password_variable)
-        return (f'oracle://{db_params.user}:{password}@'
+        return (f'oracle+oracledb://{db_params.user}:{password}@'
                 f'{db_params.host}:{db_params.port}/{db_params.dbname}')
diff --git a/test/unit/test_db_helpers.py b/test/unit/test_db_helpers.py
@@ -90,7 +90,7 @@ def test_connect(monkeypatch, db_params, driver, expected):
 
 
 @pytest.mark.parametrize('db_params, expected', [
-    (ORACLEDB, 'oracle://testuser:mypassword@server:1521/testdb'),
+    (ORACLEDB, 'oracle+oracledb://testuser:mypassword@server:1521/testdb'),
     (MSSQLDB,
      'mssql+pyodbc://testuser:mypassword@server:1521/testdb?driver=test+driver'),
     # NOQA