BUG: Fix edge cases in Slerp #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicerNewerCar
force-pushed
the
quaternion-slerp-fix
branch
from
a86db4d to
22030a4
Compare
jcfr
reviewed
Mar 25, 2024
NicerNewerCar
force-pushed
the
quaternion-slerp-fix
branch
from
22030a4 to
f6c6c5f
Compare
jcfr
reviewed
Mar 25, 2024
jcfr
reviewed
Mar 25, 2024
NicerNewerCar
force-pushed
the
quaternion-slerp-fix
branch
from
f6c6c5f to
6e26ab1
Compare
jcfr
reviewed
Mar 25, 2024
Regression initially introduced in 6b7ad8e. Slerp interpolation fails in some cases when t == 0 or t == 1
NicerNewerCar
force-pushed
the
quaternion-slerp-fix
branch
from
6e26ab1 to
510586f
Compare
jcfr
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #275
Regression initially introduced in 6b7ad8e. Slerp interpolation fails in some cases when t == 0 or t == 1