Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update schema to include clipping-range #277

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

NicerNewerCar
Copy link
Contributor

Updates camera schema ahead of BrownBiomechanics/SlicerAutoscoperM#75

@jcfr
Copy link
Contributor

jcfr commented Mar 26, 2024

Should we also update the following:

@jcfr
Copy link
Contributor

jcfr commented Apr 2, 2024

To clarify, the commit should be changed to ENH: Support loading VTK camera file with clipping-range and the function Camera::loadVTKCamera should be updated accordingly1

Footnotes

  1. https://github.com/BrownBiomechanics/Autoscoper/blob/e78b70e594b8eda8e6b92a1d91c2eb8732d1766d/libautoscoper/src/Camera.cpp#L364C6-L422

Note: clipping range is currently not used within Autoscoper,
this is used by SlicerAutoscoperM to communicate information.
@jcfr jcfr merged commit 8fe9748 into BrownBiomechanics:main Apr 3, 2024
3 checks passed
@jcfr jcfr changed the title ENH: Update schema ENH: Update schema to include clipping-range Apr 3, 2024
@NicerNewerCar NicerNewerCar deleted the update-schema branch April 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants