-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi tracking file support #293
Merged
jcfr
merged 4 commits into
BrownBiomechanics:main
from
NicerNewerCar:multi-tracking-file-support
Aug 19, 2024
Merged
Multi tracking file support #293
jcfr
merged 4 commits into
BrownBiomechanics:main
from
NicerNewerCar:multi-tracking-file-support
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicerNewerCar
force-pushed
the
multi-tracking-file-support
branch
from
August 7, 2024 15:43
f30eabf
to
a900881
Compare
@NicerNewerCar Would it be possible to display anywhere the name of the tracking file that you are looking at? |
jcfr
force-pushed
the
multi-tracking-file-support
branch
2 times, most recently
from
August 12, 2024 18:59
ee3d286
to
a0764c4
Compare
jcfr
requested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the changes are sensible. Before integrating, I suggest to perform few API name changes.
jcfr
reviewed
Aug 12, 2024
NicerNewerCar
force-pushed
the
multi-tracking-file-support
branch
2 times, most recently
from
August 13, 2024 14:38
f6ede13
to
d4fbb10
Compare
jcfr
force-pushed
the
multi-tracking-file-support
branch
from
August 19, 2024 13:34
48c8347
to
a027e68
Compare
Follow-up of 4d2eec3 ("ENH: Update interpolation to use Quaternions rather than eulers (BrownBiomechanics#255)", 2024-02-29) Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
jcfr
force-pushed
the
multi-tracking-file-support
branch
from
August 19, 2024 13:51
a027e68
to
81cf758
Compare
jcfr
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for loading multiple tracking files
Can use the shortcuts
J
andK
to swap between loaded tracking files.A "tracking set" is a context for all loaded volumes, so by adding a single extra tracking set you are able to load two tracking files for each volume.
Closes #287