Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tracking file support #293

Merged

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Aug 7, 2024

Adds support for loading multiple tracking files
Can use the shortcuts J and K to swap between loaded tracking files.
A "tracking set" is a context for all loaded volumes, so by adding a single extra tracking set you are able to load two tracking files for each volume.
Closes #287
switching_tras

@NicerNewerCar NicerNewerCar force-pushed the multi-tracking-file-support branch from f30eabf to a900881 Compare August 7, 2024 15:43
@DajungYoon
Copy link

@NicerNewerCar Would it be possible to display anywhere the name of the tracking file that you are looking at?

@jcfr jcfr force-pushed the multi-tracking-file-support branch 2 times, most recently from ee3d286 to a0764c4 Compare August 12, 2024 18:59
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes are sensible. Before integrating, I suggest to perform few API name changes.

libautoscoper/src/VolumeTransform.hpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.hpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
libautoscoper/src/VolumeTransform.cpp Outdated Show resolved Hide resolved
@NicerNewerCar NicerNewerCar force-pushed the multi-tracking-file-support branch 2 times, most recently from f6ede13 to d4fbb10 Compare August 13, 2024 14:38
@jcfr jcfr force-pushed the multi-tracking-file-support branch from 48c8347 to a027e68 Compare August 19, 2024 13:34
@jcfr jcfr force-pushed the multi-tracking-file-support branch from a027e68 to 81cf758 Compare August 19, 2024 13:51
@jcfr jcfr merged commit 347628c into BrownBiomechanics:main Aug 19, 2024
3 checks passed
@NicerNewerCar NicerNewerCar deleted the multi-tracking-file-support branch August 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queen's Feature Request - Toggling Between Tracking Files
3 participants