Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manipulating DRR position using the arrow keys #294

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Add support for manipulating DRR position using the arrow keys #294

merged 3 commits into from
Aug 19, 2024

Conversation

NicerNewerCar
Copy link
Contributor

Adds support for manipulating DRR position using the arrow keys.
Controls:

  • Left Select previous DOF.
  • Right Select next DOF.
  • Up Increment selected DOF.
  • Down Decrement selected DOF.

Selected DOF is bolded on the timeline

Vary the step size by going to Tracking-> Advanced Settings -> Step Size defaults to 1mm/deg
Closes #285
arrow_input

@NicerNewerCar NicerNewerCar force-pushed the fine-grain-dof-adjustment branch from cd63be9 to b6185cd Compare August 9, 2024 15:04
@amymmorton
Copy link
Collaborator

cool - lgtm
should @mjrainbow test too?

DajungYoon
DajungYoon reviewed Aug 12, 2024
View reviewed changes
Copy link

@DajungYoon DajungYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool Anthony! Got a thumbs up from the students in my lab.

jcfr
jcfr reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside of few nitpicks, I suggest to simplify the logic by doing the bookkeeping of the DOF being updated directly int the timeline widget.

autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.h Outdated Show resolved Hide resolved
autoscoper/src/ui/TimelineDockWidget.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/TimelineDockWidget.h Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
autoscoper/src/ui/AutoscoperMainWindow.cpp Outdated Show resolved Hide resolved
@NicerNewerCar NicerNewerCar force-pushed the fine-grain-dof-adjustment branch 2 times, most recently from 6a0fa56 to d79a13b Compare August 13, 2024 13:38
@NicerNewerCar NicerNewerCar requested a review from jcfr August 13, 2024 13:45
@jcfr jcfr force-pushed the fine-grain-dof-adjustment branch from d79a13b to 3ebb178 Compare August 19, 2024 13:28
@jcfr jcfr merged commit e440814 into BrownBiomechanics:main Aug 19, 2024
3 checks passed
@NicerNewerCar NicerNewerCar deleted the fine-grain-dof-adjustment branch August 19, 2024 13:45
@jcfr jcfr changed the title Fine grain dof adjustment Adds support for manipulating DRR position using the arrow keys Sep 6, 2024
@jcfr jcfr changed the title Adds support for manipulating DRR position using the arrow keys Add support for manipulating DRR position using the arrow keys Sep 6, 2024
@jcfr jcfr mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DajungYoon DajungYoon DajungYoon approved these changes

@amymmorton amymmorton amymmorton approved these changes

@jcfr jcfr Awaiting requested review from jcfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Queen's Feature Request - Finer Controls With Arrow Keys
4 participants
@NicerNewerCar @amymmorton @jcfr @DajungYoon