Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Volumes Generated do not spatially align with VolumeNode Input #125

Closed
amymmorton opened this issue Oct 21, 2024 · 11 comments · Fixed by #128 or #147
Closed

Partial Volumes Generated do not spatially align with VolumeNode Input #125

amymmorton opened this issue Oct 21, 2024 · 11 comments · Fixed by #128 or #147
Assignees

Comments

@amymmorton
Copy link
Contributor

As seen with Cesar's data .. I tried a 3d static ct acquired by Dr Lalon'es group:

spatial mismatch of generated tfm/tiffs:

image

nrrd and seg

@amymmorton
Copy link
Contributor Author

for ref: this is a bilateral hand/wrist ct scan, proper seg:

image

@amymmorton
Copy link
Contributor Author

amymmorton commented Oct 23, 2024

edit - trying to define exact cases where partial volumes (tiff) and tfm are correct and when they are not
'example fail of previously processed (working) data set:
image

@jcfr
Copy link
Contributor

jcfr commented Oct 23, 2024

Thanks for feedback.

To support you with the demo, we provides you with extension packages for the past few version, that way you could install it locally and use the version that works. Let us know if that would help.

Looks like our testing didn't account for this dataset and/or usecase.

We should work together to identify which changes introduced the regression.

For reference, here are the recent SlicerAutoscoperM changes:

image

@amymmorton
Copy link
Contributor Author

amymmorton commented Oct 23, 2024

IN regards to this data

loaded from nrrd and seg

IN Slicer/Slicer@c6b01db correct PV formed.

sourcebuild lib zip in Gdrive link as well

scmrevision 2e483f4

@amymmorton
Copy link
Contributor Author

dataset (sid) segmentation type link align screenshot
WRIST BVR (WN00112) STL Model link image
THUMB 3DCT (BN00124) STL Model link image
KNEE BVR (CXBM15) STL Model link image
BILATERL HAND CT STL Model link
image

@sbelsk
Copy link
Contributor

sbelsk commented Nov 5, 2024

Reopening as #128 didn't resolve the problem, but fixed a related bug.

@sbelsk sbelsk reopened this Nov 5, 2024
@amymmorton
Copy link
Contributor Author

amymmorton commented Nov 13, 2024

Tue Nov 12 2024 (Revision: 34fa24c)
WRIST BVR (WN00112) link

Al PV correct EXCEPT the cropped volume node use case(last)

image

segmentation type align screenshot
STL Model image image
Auto Seg image
Auto Seg (from crop roi, Partial V original neutral) image
Auto Seg (from crop roi, Partial V CROP neutral) image

@amymmorton
Copy link
Contributor Author

Tue Nov 12 2024 (Revision: 34fa24c)

BILATERL HAND CT

Import to dicom db from file (rather than previously saved .nrrd)
image

segmentation type align screenshot
auto seg image

|

@amymmorton
Copy link
Contributor Author

amymmorton commented Nov 13, 2024

@jcfr

Could the issue be with the IJK - RAS (LPS) differences:

WRIST: (successful) BILATERAL: (fail)
image image
image image

@amymmorton
Copy link
Contributor Author

MUST BE!

When the only diff between original and cropped as well!
image

image

@sbelsk
Copy link
Contributor

sbelsk commented Nov 16, 2024

Excellent find, thanks for looking into it! I opened #147, which should fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment