Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Improve and export Slicer2AUT transform #109

Merged
merged 2 commits into from
Jul 17, 2024
Merged

ENH: Improve and export Slicer2AUT transform #109

merged 2 commits into from
Jul 17, 2024

Conversation

NicerNewerCar
Copy link
Contributor

Closes #107
Closes #102

@NicerNewerCar NicerNewerCar force-pushed the tra-offset-bug branch 2 times, most recently from 25dfbc3 to 223af02 Compare June 25, 2024 17:26
@NicerNewerCar NicerNewerCar marked this pull request as ready for review June 25, 2024 17:27
@NicerNewerCar NicerNewerCar requested review from jcfr and amymmorton June 25, 2024 17:28
@NicerNewerCar NicerNewerCar requested a review from jcfr July 1, 2024 16:23
@NicerNewerCar NicerNewerCar force-pushed the tra-offset-bug branch 2 times, most recently from cb85a54 to d357f97 Compare July 10, 2024 18:30
jcfr
jcfr reviewed Jul 17, 2024
View reviewed changes
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
jcfr
jcfr reviewed Jul 17, 2024
View reviewed changes
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
jcfr
jcfr reviewed Jul 17, 2024
View reviewed changes
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
jcfr
jcfr reviewed Jul 17, 2024
View reviewed changes
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
@NicerNewerCar NicerNewerCar requested a review from jcfr July 17, 2024 19:04
jcfr
jcfr reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying tweaks 👍

AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Outdated Show resolved Hide resolved
AutoscoperM/AutoscoperM.py Show resolved Hide resolved
@NicerNewerCar
ENH: Improve and export Slicer2AUT transform
b786faf
@NicerNewerCar
BUG: Fix partial volume flip
b37fd41 
Regression introduced in e036c22 where,
on config generation, the partial volumes would be automatically flipped
in the x and y directions. This caused issues with post-processing.
@NicerNewerCar NicerNewerCar merged commit de29b1e into BrownBiomechanics:main Jul 17, 2024
2 checks passed
@NicerNewerCar NicerNewerCar deleted the tra-offset-bug branch July 17, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfr jcfr jcfr left review comments

@amymmorton amymmorton Awaiting requested review from amymmorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NicerNewerCar @jcfr