ENH: Improve pre-processing error handling for UI user friendliness #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amymmorton
approved these changes
Jan 8, 2025
jcfr
reviewed
Jan 13, 2025
|
Thanks for addressing this 🙏 After addressing few nitpicks and renaming |
Co-authored-by: Jean-Christophe Fillion-Robin <[email protected]>
sbelsk
force-pushed
the
improve-pre-processing-errors
branch
from
38ef7aa to
eb36015
Compare
jcfr
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #141, this PR improves the error reporting of the pre-processing module for better user friendliness. Namely, the error handling code was refactored to better report a meaningful error message to the UI user when an exception is raised (like what specific field(s) has the invalid value). The error is still reported to the error log for CLI users.