Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Revisit initialization of Autoscoper_RENDERING_BACKEND #65

Merged

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Oct 18, 2023

Revisit approach originally introduced in 6912ab0 (ENH: Enable CUDA on Windows and Linux) through #64 to support initializing Autoscoper_RENDERING_BACKEND based on env. variable of the same name.

This will allow to enable the CUDA rendering backend only in build environment where CUDA is available.

Revisit approach originally introduced in 6912ab0 (ENH: Enable CUDA on
Windows and Linux) to support initializing Autoscoper_RENDERING_BACKEND
based on env. variable of the same name.

This will allow to enable the CUDA rendering backend only in build environment
where CUDA is available.
@jcfr jcfr force-pushed the revisit-rendering-backend-cmake-var-setting branch from 31c6394 to 3d14d76 Compare October 18, 2023 22:02
@jcfr
Copy link
Contributor Author

jcfr commented Oct 18, 2023

Example of output obtained from an existing build tree:

$ cmake .
[...]
-- Setting Autoscoper_RENDERING_BACKEND to OpenCL (initialized from default value)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- Configuring done
-- Generating done

$ Autoscoper_RENDERING_BACKEND=CUDA cmake -UAutoscoper_RENDERING_BACKEND .
[...]
-- Setting Autoscoper_RENDERING_BACKEND to CUDA (initialized from env. variable)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- Configuring done
-- Generating done

$ Autoscoper_RENDERING_BACKEND=OpenCL cmake -UAutoscoper_RENDERING_BACKEND .
[...]
-- Setting Autoscoper_RENDERING_BACKEND to OpenCL (initialized from env. variable)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- Configuring done
-- Generating done

$ cmake -UAutoscoper_RENDERING_BACKEND .
[...]
-- Setting Autoscoper_RENDERING_BACKEND to OpenCL (initialized from default value)
-- SuperBuild - First pass
-- SuperBuild - First pass - done
[...]
-- Configuring done
-- Generating done

@jcfr jcfr requested a review from NicerNewerCar October 18, 2023 22:25
@jcfr jcfr merged commit 34d434e into BrownBiomechanics:main Oct 19, 2023
2 checks passed
@jcfr jcfr deleted the revisit-rendering-backend-cmake-var-setting branch October 19, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants