Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "unread" tab Attribute #3570

Conversation

goodusername123
Copy link
Contributor

@goodusername123 goodusername123 commented Oct 13, 2024

This restore the "unread" tab Attribute that was controversially removed all the way back in Firefox 61. This Attribute is useful for theming since it allows custom CSS styling for tabs that has been opened in the background but haven't been actually viewed yet.

To test simply add something such as this to userChrome.css:

#tabbrowser-tabs tab[unread="true"]
{
	font-style: italic !important;
	color: red !important;
}
Semi off-topic The pull request for updating Twemoji to 15.1.0 (pull 3513) is seemly not preset in the `current` branch for Waterfox 6.5.0 if possible please pull this into the current branch as it is still relevant in the context of ESR128.

MrAlex94 and others added 30 commits October 10, 2024 10:40
Ideally we wouldn't have to modify other files alongside - but it seems the .mozconfig doesn't override as it should.

[WFX-358] Fix .mozconfig for linux.
Also includes:

* [WFX-208] Improve support for bootstrapped extensions.
Added support for custom preference pages.
* [WFX-208] Fix incorrect loading order for bootstrap loader.
* [WFX-394] Fix BootstrapLoader. (BrowserWorks#2727)
Also includes:
[WFX-186] Update GitHub Actions.

Make sure we now package l10n files and have separate naming for ARM files on macOS.

[WFX-249] Update GitHub Actions

Squash of individual commits:

[WFX-249] Add release action for current.

[WFX-249] Use dispatch input for version number in release workflow.

[WFX-249] Disable certain release triggers until ready for mass deployment.

[WFX-249] Dry run AUS.

[WFX-249] Add a pull workflow, improve staging/release process.

[WFX-249] Attempt to set AWS env vars to prevent errors.

[WFX-249] Update runners to handle stub-installer.

[WFX-360] Improve AUS upload code for release.yml

[WFX-186] Update PR workflow

Co-Authored-By: adamp01 <[email protected]>
Use our own search extensions instead of Mozilla's.
DO NOT modify license notices.
MrAlex94 and others added 25 commits October 10, 2024 10:42
Also format document to follow best practices.
Makes it so that the icon for the main EXE/logo displays properly at different sizes by adding pre-scaled image sizes like .ico wants. note: each of the generated image sizes has proper gamma correct scaling.
- Implement tocbot library for generating table of contents
- Modify general.js to initialize and handle table of contents generation
- Update preferences-general.xhtml to include tocbot styles and scripts
- Add placeholder for table of contents in the preferences UI
- Implement smooth scrolling and highlighting for table of contents items
- Adjust styling for table of contents to match preferences design
* Fix "Autohide" behavior of the Waterfox Sidebar for full screen mode
    It was caused by the difference of the spec of -moz-bool-pref between ESR115 and ESR128. Now codes have been renewed for ESR128.
* Fix an error opening option page
    It failed to run the initializer function on some cases. Now the initializer is retried with delay.
* Fix "Bookmark Selected Tabs" command
    It was caused by the difference of the Places modules between ESR115 and ESR128. Now codes have been renewed for ESR128.
* Fix Tab preview feature with browser.tabs.hoverPreview.enabled=true
    It was largely reconstructured on Firefox, thus I've updated codes for the current implementation.
* Fix behavior of F1 key not to toggle the Waterfox Sidebar
    It happened when the "key" XUL element is re-inserted dynamically. Now the first inserted element is reused after reinstallation of the sidebar module.
* Fix the behavior of "Reset to default" operation in the toolbar customization
    It was caused by an unhandled error in Firefox's toolbar customization module. I've implemented a mechanism to reset toolbar customizations until insertion of the tabs sidebar button succeed.
This restore the `unread` tab Attribute that was removed all the way back in Firefox 61.
This is useful for theming since it allows custom CSS styling for tabs that has been opened in the background but haven't been actually viewed yet.

https://bugzilla.mozilla.org/show_bug.cgi?id=1453957
@goodusername123
Copy link
Contributor Author

uh It seems like this pull request got kinda messed up from the current branch getting changed is there anything I need to do on my end or are you able to just pull in the one commit that is relevant to this pull request?

@MrAlex94
Copy link
Collaborator

bd954c1

@MrAlex94 MrAlex94 closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants