Changed Sensor Constructors to allow Variable Polling Frequency #39
Conversation
matthewcn56
changed the title
Changed code modifications to abide with coding conventions within repo, still running into datapacket.cpp issues when attempting to build however
| @@ -21,21 +21,24 @@ namespace spartan { | |||
| virtual int powerOn() = 0; | |||
| virtual int powerOff() = 0; | |||
| virtual int poll(MasterDataPacket &dp) = 0; | |||
|
|
|||
There was a problem hiding this comment.
Remove unneeded indentation to keep proper style.
| LSM6DS33(int busID, int lsm6ID, lsm6Settings settings); | ||
| LSM6DS33(int busID, int lsm6ID); | ||
| LSM6DS33(int busID, int lsm6ID, int polling_frequency, lsm6Settings settings); | ||
| LSM6DS33(int busID, int lsm6IDm, int polling_frequency); |
There was a problem hiding this comment.
Is there a reason why we changed the second parameter to lsm6ID to lsm6IDm? This probably should be producing a compilation error.
|
Hm.... @matthewcn56 I realize that this PR is trying to implement the same thing as what PR #38 opened by @allosaurus7000 is doing... can we perhaps combine these changes into one PR? or abandon one in favor of the other? Many of the comments and requested changes I put on the other PR are partially or completely implemented by this PR, so that's great! If I had to say which one we should work off of, I'd say it'd probably be this one. |
Sounds good! I'll check in with him rn and see if we can merge changes to here |
|
Go ahead! Sorry, I’ve been a little busy with some personal issues, but I
can be available later tonight. Make whatever changes you want rn
…On Sun, Jan 24, 2021 at 5:15 PM Matthew Nieva ***@***.***> wrote:
Hm.... @matthewcn56 <https://github.com/matthewcn56> I realize that this
PR is trying to implement the same thing as what PR #38
<#38> opened by
@allosaurus7000 <https://github.com/allosaurus7000> is doing... can we
perhaps combine these changes into one PR? or abandon one in favor of the
other?
Many of the comments and requested changes I put on the other PR are
partially or completely implemented by this PR, so that's great! If I had
to say which one we should work off of, I'd say it'd probably be this one.
Sounds good! I'll check in with him rn and see if we can merge changes to
here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#39 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOJCHD4DRGHSBUQPA5UOFDDS3TA2VANCNFSM4UM2VIUA>
.
|
I assume that getTimeMillis and the other functions will be handled inside the implementation of the sensor polling functions themselves, and not part of this pull request?
Closes #29.
When I try running the build command, it says that there is a fatal error inside of the data packet.cpp file, but I did not edit that file.