Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/118 #119

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Feature/118 #119

merged 4 commits into from
Mar 17, 2024

Conversation

thxtome
Copy link
Collaborator

@thxtome thxtome commented Mar 17, 2024

⛓ Related Issues

📋 작업 내용

  • 체크박스 컴포넌트 추가
  • 약관페이지 비회원도 볼 수 있게 권한 처리
  • 회원가입 프로세스에 약관동의 추가

체크박스 컴포넌트 추가
비회원 접근 가능을 위한 tos 관련 페이지 경로 수정
Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
popo-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 10:47am

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.05882% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.26%. Comparing base (9eb5932) to head (7602c8e).

Files Patch % Lines
src/components/common/Checkbox.tsx 95.65% 1 Missing ⚠️
src/components/signup/StepField/TosField.tsx 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   95.26%   95.26%   -0.01%     
==========================================
  Files         149      152       +3     
  Lines        1837     1878      +41     
  Branches      199      208       +9     
==========================================
+ Hits         1750     1789      +39     
- Misses         81       83       +2     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundle Sizes

Compared against 9eb5932

Route: No significant changes found

Dynamic import: No significant changes found

@thxtome thxtome merged commit 74eb159 into main Mar 17, 2024
9 checks passed
Copy link

⚡️ 1 Lighthouse report!

Category Score
🟠 Performance 56
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟢 PWA 90
Category Score
🟢 First Contentful Paint 1.4 s
🔴 Time to Interactive 10.1 s
🔴 Speed Index 10.6 s
🟢 Total Blocking Time 170 ms
🔴 Largest Contentful Paint 15.6 s
🟢 Cumulative Layout Shift 0

⚡️ 2 Lighthouse report!

Category Score
🟠 Performance 60
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟢 PWA 90
Category Score
🟢 First Contentful Paint 1.4 s
🔴 Time to Interactive 9.1 s
🔴 Speed Index 8.6 s
🟢 Total Blocking Time 60 ms
🔴 Largest Contentful Paint 15.6 s
🟢 Cumulative Layout Shift 0

⚡️ 3 Lighthouse report!

Category Score
🟠 Performance 59
🟢 Accessibility 90
🟢 Best Practices 92
🟢 SEO 100
🟢 PWA 90
Category Score
🟢 First Contentful Paint 1.4 s
🔴 Time to Interactive 9.1 s
🔴 Speed Index 8.8 s
🟢 Total Blocking Time 70 ms
🔴 Largest Contentful Paint 15.6 s
🟢 Cumulative Layout Shift 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sign] 회원가입시 약관 동의
2 participants