Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(session): read user from db when loading session #1114

Merged
merged 3 commits into from
May 13, 2024
Merged

chore(session): read user from db when loading session #1114

merged 3 commits into from
May 13, 2024

Conversation

onyxvd
Copy link
Collaborator

@onyxvd onyxvd commented Apr 29, 2024

No description provided.

@onyxvd onyxvd requested a review from groupsky April 29, 2024 08:41
groupsky
groupsky requested changes Apr 29, 2024
View reviewed changes
Copy link
Member

@groupsky groupsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we don't use the stored user in redis, no need to put it there in the first place

server/initializers/session.js Outdated Show resolved Hide resolved
server/initializers/session.js Outdated Show resolved Hide resolved
@onyxvd onyxvd force-pushed the chore/refresh-user-in-session branch from 2ab6a05 to 7c55c77 Compare April 29, 2024 12:18
@onyxvd onyxvd requested a review from groupsky May 8, 2024 10:37
@onyxvd onyxvd merged commit 27b3a8e into master May 13, 2024
11 checks passed
@onyxvd onyxvd deleted the chore/refresh-user-in-session branch May 13, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groupsky groupsky Awaiting requested review from groupsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onyxvd @groupsky