Merge pull request #185 from ZephyrZenn/main

fix: correctly set cookies
BuilderIO · Jan 23, 2025 · 50f85a3 · 50f85a3
2 parents 2ca876e + 90c446e
commit 50f85a3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,8 @@
 # [1.5.0](https://github.com/BuilderIO/gpt-crawler/compare/v1.4.0...v1.5.0) (2024-07-05)
 
-
 ### Features
 
-* git clone depth limit in docker ([87767db](https://github.com/BuilderIO/gpt-crawler/commit/87767dbda99b3259d44ec2c02dceb3a59bb2ca3c))
+- git clone depth limit in docker ([87767db](https://github.com/BuilderIO/gpt-crawler/commit/87767dbda99b3259d44ec2c02dceb3a59bb2ca3c))
 
 # [1.4.0](https://github.com/BuilderIO/gpt-crawler/compare/v1.3.0...v1.4.0) (2024-01-15)
 

diff --git a/src/core.ts b/src/core.ts
@@ -104,25 +104,28 @@ export async function crawl(config: Config) {
         // Uncomment this option to see the browser window.
         // headless: false,
         preNavigationHooks: [
-          // Abort requests for certain resource types
-          async ({ request, page, log }) => {
-            // If there are no resource exclusions, return
-            const RESOURCE_EXCLUSTIONS = config.resourceExclusions ?? [];
-            if (RESOURCE_EXCLUSTIONS.length === 0) {
-              return;
-            }
+          // Abort requests for certain resource types and add cookies
+          async (crawlingContext, _gotoOptions) => {
+            const { request, page, log } = crawlingContext;
+            // Add cookies to the page
+            // Because the crawler has not yet navigated to the page, so the loadedUrl is always undefined. Use the request url instead.
             if (config.cookie) {
               const cookies = (
                 Array.isArray(config.cookie) ? config.cookie : [config.cookie]
               ).map((cookie) => {
                 return {
                   name: cookie.name,
                   value: cookie.value,
-                  url: request.loadedUrl,
+                  url: request.url,
                 };
               });
               await page.context().addCookies(cookies);
             }
+            const RESOURCE_EXCLUSTIONS = config.resourceExclusions ?? [];
+            // If there are no resource exclusions, return
+            if (RESOURCE_EXCLUSTIONS.length === 0) {
+              return;
+            }
             await page.route(
               `**\/*.{${RESOURCE_EXCLUSTIONS.join()}}`,
               (route) => route.abort("aborted"),