-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat angular signals #1731
base: main
Are you sure you want to change the base?
Feat angular signals #1731
Conversation
# Conflicts: # packages/core/src/generators/angular/blocks.ts
🦋 Changeset detectedLatest commit: 9fbe2ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
View your CI Pipeline Execution ↗ for commit 9fbe2ee.
☁️ Nx Cloud last updated this comment at |
# Conflicts: # packages/core/src/__tests__/__snapshots__/stencil.test.ts.snap
@samijaber I'm excited to hear what you think about this one :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nmerget This is a MONSTER PR 🙏🏽
We have this exact need internally for outputting Signals in Angular and were going to start tackling it in a few weeks. Such a happy coincidence you just put this PR up!
Our team will review this shortly. Very excited to have this feature merged in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create a new angular e2e test that uses the signals
API? Just to make sure it works at a basic level and renders some components.
If that turns out to be too tricky, then at the very least update the existing e2e-angular test to use api: 'signals'
Yes, great idea. I'll copy paste the current |
Hmm the copy&paste wouldn't work so easily. I'll convert it to |
Description
Please provide the following information:
Angular v18+ uses signals as a new feature.
This allows the generator to match better with other targets.
This PR will rewrite the complete Angular generator to match all new features for Angular
Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:
yarn fmt:prettier
.yarn test:update
yarn g:changeset
and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.