Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat angular signals #1731

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

nmerget
Copy link
Contributor

@nmerget nmerget commented Mar 20, 2025

Description

Please provide the following information:

Angular v18+ uses signals as a new feature.
This allows the generator to match better with other targets.

This PR will rewrite the complete Angular generator to match all new features for Angular

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 9fbe2ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Minor
@builder.io/mitosis-cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Mar 20, 2025

View your CI Pipeline Execution ↗ for commit 9fbe2ee.

Command Status Duration Result
nx run-many --target test ✅ Succeeded 5m 5s View ↗
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 7s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 45s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-27 16:01:35 UTC

@nmerget nmerget marked this pull request as ready for review March 27, 2025 11:28
@nmerget nmerget requested a review from samijaber as a code owner March 27, 2025 11:28
@nmerget
Copy link
Contributor Author

nmerget commented Mar 27, 2025

@samijaber I'm excited to hear what you think about this one :D

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerget This is a MONSTER PR 🙏🏽

We have this exact need internally for outputting Signals in Angular and were going to start tackling it in a few weeks. Such a happy coincidence you just put this PR up!

Our team will review this shortly. Very excited to have this feature merged in!

cc @sidmohanty11

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a new angular e2e test that uses the signals API? Just to make sure it works at a basic level and renders some components.

If that turns out to be too tricky, then at the very least update the existing e2e-angular test to use api: 'signals'

@nmerget
Copy link
Contributor Author

nmerget commented Mar 27, 2025

Can we create a new angular e2e test that uses the signals API? Just to make sure it works at a basic level and renders some components.

If that turns out to be too tricky, then at the very least update the existing e2e-angular test to use api: 'signals'

Yes, great idea. I'll copy paste the current e2e-angular to test both

@samijaber samijaber requested a review from sidmohanty11 March 27, 2025 13:43
@nmerget
Copy link
Contributor Author

nmerget commented Mar 27, 2025

Can we create a new angular e2e test that uses the signals API? Just to make sure it works at a basic level and renders some components.
If that turns out to be too tricky, then at the very least update the existing e2e-angular test to use api: 'signals'

Yes, great idea. I'll copy paste the current e2e-angular to test both

Hmm the copy&paste wouldn't work so easily. I'll convert it to api=signals it should be the default in the near future anyways: https://angular.dev/reference/releases#actively-supported-versions

@nmerget nmerget requested a review from samijaber March 27, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants