Skip to content
This repository was archived by the owner on Jun 22, 2020. It is now read-only.

2883612 - Fix PHP notice when trying to change the format for the author name. #334

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

mxhCodes
Copy link

@mxhCodes mxhCodes commented Jun 7, 2017

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@mxhCodes
Copy link
Author

mxhCodes commented Jun 7, 2017

This PR only addresses to fix the PHP notice occurring on missing fields, nothing more.
There are other PRs like this one which aim to solve the issue of displaying the author.

@dbosen dbosen merged commit d759081 into develop Jun 7, 2017
@dbosen dbosen deleted the hotfix/notice-author-name branch June 7, 2017 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants