Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new operators and some counters for them + Readme update #250

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

lilyhuang-github
Copy link
Contributor

Changed the minimum version for NPM and Node in the readme and also added the new operators

@BurkusCat
Copy link
Owner

Amazing work! It is so awesome to have things brought up to date, you've really nailed the format of the counters :)


let solis = new Operator(r6operators.solis, operatorId.solis, "Operation Solar Raid");

// solis.addCounterNode(r6operators.blitz, counterType.hard, "Solis' visor can detect Blitz's shield while being held and therefore him.")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these ones be commented out?


let brava = new Operator(r6operators.brava, operatorId.brava, "Operation Commanding Force");

brava.addCounterNode(operatorId.alibi, counterType.minor, "Brava's Krudge drone can hack Alibi's prismas");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain, are you able to make sure any new ones you've added have a full stop / period at the end, please?

brava.addCounterNode(operatorId.ela, counterType.soft, "Brava's Krudge drone can hack Ela's grzmot mines");
brava.addCounterNode(operatorId.jager, counterType.soft, "Brava's Krudge drone can hack Jager's ADS");
brava.addCounterNode(operatorId.kapkan, counterType.soft, "Brava's Krudge drone can hack Kapkan's EDDs");
brava.addCounterNode(operatorId.maestro, counterType.hard, "Brava's Krudge drone can hack Maestro's evil eye and controll it");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of the Brava counters have a typo for "control"

@BurkusCat
Copy link
Owner

Hi @lilyhuang-github , sorry for the delay, I thought I submitted this review but I clearly hadn't!

@m-krebs
Copy link

m-krebs commented Oct 22, 2024

Looking through the counters I noticed that at many places Thatcher counters electrical devices by "destroying" them, e.g.: Bandit.
It might be worth to include a change for this, in the current PR. I might do it myself later on, if you do not want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants