-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the new operators and some counters for them + Readme update #250
base: master
Are you sure you want to change the base?
Conversation
Merge pull request BurkusCat#249 from lilyhuang-github/master
Amazing work! It is so awesome to have things brought up to date, you've really nailed the format of the counters :) |
|
||
let solis = new Operator(r6operators.solis, operatorId.solis, "Operation Solar Raid"); | ||
|
||
// solis.addCounterNode(r6operators.blitz, counterType.hard, "Solis' visor can detect Blitz's shield while being held and therefore him.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these ones be commented out?
|
||
let brava = new Operator(r6operators.brava, operatorId.brava, "Operation Commanding Force"); | ||
|
||
brava.addCounterNode(operatorId.alibi, counterType.minor, "Brava's Krudge drone can hack Alibi's prismas"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a pain, are you able to make sure any new ones you've added have a full stop / period at the end, please?
brava.addCounterNode(operatorId.ela, counterType.soft, "Brava's Krudge drone can hack Ela's grzmot mines"); | ||
brava.addCounterNode(operatorId.jager, counterType.soft, "Brava's Krudge drone can hack Jager's ADS"); | ||
brava.addCounterNode(operatorId.kapkan, counterType.soft, "Brava's Krudge drone can hack Kapkan's EDDs"); | ||
brava.addCounterNode(operatorId.maestro, counterType.hard, "Brava's Krudge drone can hack Maestro's evil eye and controll it"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of the Brava counters have a typo for "control"
Hi @lilyhuang-github , sorry for the delay, I thought I submitted this review but I clearly hadn't! |
Looking through the counters I noticed that at many places Thatcher counters electrical devices by "destroying" them, e.g.: Bandit. |
Changed the minimum version for NPM and Node in the readme and also added the new operators