Add option to ignore nested git repositories #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneduffield
force-pushed
the
ignoreNestedRepos
branch
from
3412b26 to
28c3b64
Compare
This implements the suggestion made in BurntSushi#23 to provide an option to ignore nested git repositories. A nested git repository is identified by the presence of a .git file or directory. It's a directory in the regular case, but it's a file for git worktrees and git submodules. This option is disabled by default.
zaneduffield
force-pushed
the
ignoreNestedRepos
branch
from
28c3b64 to
e886ad0
Compare
|
I'm successfully using this in one of my repos with submodules. Thanks! |
|
Any updates on this? |
|
It seems like there isn't much interest in getting this merged. I'm closing it for now. |
|
FWIW, the maintainer has little time to review PRs, and merges them by rollups when he finds time for that. I'd let this open if you still want this to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion made in #23 to provide an option to ignore nested git repositories.
A nested git repository is identified by the presence of a .git file or directory. It's a directory in the regular case, but it's a file for git worktrees and git submodules.
This option is disabled by default.
I'm open to suggestions for better names for things. In particular I'm not sure about the name
ignore_nested_git_repoused inIgnoreOptionsandIgnoreBuilderbecause the concept of 'nesting' is outside of that layer; it has no knowledge of the level of aDirEntryand relies on the calling code to make sure that the level 0 directory is never ignored.