Skip to content
This repository has been archived by the owner on Apr 2, 2024. It is now read-only.

feat(579): mock redis to reduce info logs #588

Closed
wants to merge 1 commit into from

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Mock redis in tests to reduce the number of logs

@pawellewandowski98 pawellewandowski98 self-assigned this Feb 21, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner February 21, 2024 11:14
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@mergify mergify bot added the feature Any new significant addition label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (375adbd) 59.98% compared to head (5b5936d) 59.98%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   59.98%   59.98%           
=======================================
  Files         101      101           
  Lines        7323     7323           
=======================================
  Hits         4393     4393           
  Misses       2493     2493           
  Partials      437      437           
Flag Coverage Ξ”
unittests 59.98% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update dde5783...5b5936d. Read the comment docs.

@arkadiuszos4chain arkadiuszos4chain self-requested a review February 21, 2024 11:24
Copy link
Contributor

@dorzepowski dorzepowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for inconvenience.
Those changes need to be moved into spv-wallet after renaming.

@mergify mergify bot closed this Mar 13, 2024
Copy link
Contributor

mergify bot commented Mar 13, 2024

This pull request looks stale. Feel free to reopen it if you think it's a mistake.

@mergify mergify bot added the stale Old, unused, stale label Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Any new significant addition stale Old, unused, stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants