Merge pull request #132 from ByteInternet/feature/reuse-brancher

Wait for reused branche when it's still being created
ByteInternet · Jan 9, 2025 · fe68f78 · fe68f78
2 parents 27a71ae + 9e1624e
commit fe68f78
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/Brancher/BrancherHypernodeManager.php b/src/Brancher/BrancherHypernodeManager.php
@@ -129,8 +129,8 @@ public function waitForAvailability(string $brancherHypernode, int $timeout = 15
             try {
                 $flows = $this->hypernodeClient->logbook->getList($brancherHypernode);
                 $relevantFlows = array_filter($flows, fn(Flow $flow) => $flow->name === 'ensure_app');
-                $failedFlows = array_filter($flows, fn(Flow $flow) => $flow->isReverted());
-                $completedFlows = array_filter($flows, fn(Flow $flow) => $flow->isComplete());
+                $failedFlows = array_filter($relevantFlows, fn(Flow $flow) => $flow->isReverted());
+                $completedFlows = array_filter($relevantFlows, fn(Flow $flow) => $flow->isComplete());
 
                 if (count($failedFlows) === count($relevantFlows)) {
                     throw new CreateBrancherHypernodeFailedException();

diff --git a/src/DeployRunner.php b/src/DeployRunner.php
@@ -291,22 +291,24 @@ private function maybeConfigureBrancherServer(Server $server, bool $reuseBranche
             $data['labels'] = $labels;
             if ($reuseBrancher && $brancherApp = $this->brancherHypernodeManager->reuseExistingBrancherHypernode($parentApp, $labels)) {
                 $this->log->info(sprintf('Found existing brancher Hypernode, name is %s.', $brancherApp));
-                $server->setHostname(sprintf("%s.hypernode.io", $brancherApp));
             } else {
                 $brancherApp = $this->brancherHypernodeManager->createForHypernode($parentApp, $data);
                 $this->log->info(sprintf('Successfully requested brancher Hypernode, name is %s.', $brancherApp));
-                $server->setHostname(sprintf("%s.hypernode.io", $brancherApp));
                 $this->brancherHypernodesRegistered[] = $brancherApp;
+            }
 
-                try {
-                    $this->log->info('Waiting for brancher Hypernode to become available...');
-                    $this->brancherHypernodeManager->waitForAvailability($brancherApp);
-                    $this->log->info('Brancher Hypernode has become available!');
-                } catch (CreateBrancherHypernodeFailedException | TimeoutException $e) {
+            try {
+                $this->log->info('Waiting for brancher Hypernode to become available...');
+                $this->brancherHypernodeManager->waitForAvailability($brancherApp);
+                $this->log->info('Brancher Hypernode has become available!');
+            } catch (CreateBrancherHypernodeFailedException | TimeoutException $e) {
+                if (in_array($brancherApp, $this->brancherHypernodesRegistered)) {
                     $this->brancherHypernodeManager->cancel($brancherApp);
-                    throw $e;
                 }
+
+                throw $e;
             }
+            $server->setHostname(sprintf("%s.hypernode.io", $brancherApp));
         }
     }