Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for php84 update dependancies #130

Open
wants to merge 3 commits into
base: add-support-for-php84
Choose a base branch
from
Open

Add support for php84 update dependancies #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c777d0
Update php-di/php-di to ^7.0
Jan 9, 2025
d96cf2f
Fix deprecated warning about vars in strings
Jan 9, 2025
a79fdd7
Dropping php7.4 to support php-di:^7
Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ jobs:
strategy:
matrix:
php_version:
- "7.4"
- "8.0"
- "8.1"
- "8.2"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
integration_test:
strategy:
matrix:
php_version: [8.1, 8.2] # 8.3 is disabled for now, since Magento 2 does not support this yet.
php_version: [8.0, 8.1, 8.2, 8.3] # 8.4 is disabled for now, since Magento 2 does not support this yet.
testsuite: [general, brancher]
runs-on: ubuntu-latest
steps:
Expand All @@ -19,12 +19,12 @@ jobs:
env:
PHP_VERSION: ${{ matrix.php_version }}
- name: Start SSH agent for brancher testsuite
if: ${{ matrix.testsuite == 'brancher' && matrix.php_version == '8.2' }}
if: ${{ matrix.testsuite == 'brancher' && matrix.php_version == '8.3' }}
uses: webfactory/[email protected]
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY }}
- name: Run brancher testsuite
if: ${{ matrix.testsuite == 'brancher' && matrix.php_version == '8.2' }}
if: ${{ matrix.testsuite == 'brancher' && matrix.php_version == '8.3' }}
run: ./runtests.sh brancher
shell: bash
env:
Expand All @@ -34,7 +34,7 @@ jobs:
code_quality:
strategy:
matrix:
php_version: [7.4, 8.1, 8.2, 8.3, 8.4]
php_version: [8.0, 8.1, 8.2, 8.3, 8.4]
runs-on: ubuntu-latest
steps:
- name: Checkout hypernode-deploy
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"guzzlehttp/guzzle": "^7.5",
"hypernode/api-client": "^0.4",
"hypernode/deploy-configuration": "^3.2",
"php-di/php-di": "^6.0",
"php-di/php-di": "^7.0",
"psr/log": "^1.0",
"symfony/console": "^5.4",
"symfony/finder": "^5.4",
Expand Down
75 changes: 15 additions & 60 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/Bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private function initContainer(): Container
{
$builder = new ContainerBuilder();
$builder->useAutowiring(true);
$builder->useAnnotations(true);
$builder->useAttributes(true);
$builder->addDefinitions(Di\ConsoleDefinition::getDefinition());
$builder->addDefinitions([
'version' => $this->getVersion(),
Expand Down
4 changes: 2 additions & 2 deletions src/DeployRunner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ private function configureDeployerTask(Task $deployerTask, TaskConfigurationInte
if ($stage) {
$deployerTask->select(
sprintf(
"stage=${stage}&roles=%s",
implode(",stage=${stage}&roles=", $roles)
"stage={$stage}&roles=%s",
implode(",stage={$stage}&roles=", $roles)
)
);
} else {
Expand Down
Loading