fix lint issues

backend/ftp/file_test.go

@@ -1127,8 +1127,8 @@ func (ts *fileTestSuite) TestURI() {
 	ts.Equal(expected, ts.testFile.URI(), "URI test")
 
 	expected = "ftp://domain.com%[email protected]:22/some/path/to/file.txt"
-	fs := NewFileSystem()
-	f, err := fs.NewFile("domain.com%[email protected]:22", "/some/path/to/file.txt")
+	fsys := NewFileSystem()
+	f, err := fsys.NewFile("domain.com%[email protected]:22", "/some/path/to/file.txt")
 	ts.NoError(err)
 	ts.Equal(expected, f.URI(), "URI test")
 }

backend/ftp/location_test.go

@@ -324,7 +324,7 @@ func (lt *locationTestSuite) TestURI() {
 	lt.Equal("ftp://[email protected]/blah/file.txt", file.URI(), "file uri with user, pass, host")
 
 	authority = `domain.com\[email protected]`
-	file, err = lt.ftpfs.NewFile(authority, "/blah/file.txt")
+	_, err = lt.ftpfs.NewFile(authority, "/blah/file.txt")
 	lt.Error(err)
 	lt.ErrorContains(err, "net/url: invalid userinfo", "file uri with bad user")
 

backend/sftp/location_test.go

@@ -157,7 +157,7 @@ func (lt *locationTestSuite) TestURI() {
 	lt.Equal("sftp://[email protected]/blah/file.txt", file.URI(), "file uri with user, pass, host")
 
 	authority = `domain.com\[email protected]`
-	file, err = lt.sftpfs.NewFile(authority, "/blah/file.txt")
+	_, err = lt.sftpfs.NewFile(authority, "/blah/file.txt")
 	lt.Error(err)
 	lt.ErrorContains(err, "net/url: invalid userinfo", "file uri with bad user")
 

utils/authority.go

@@ -28,15 +28,11 @@ import (
      pct-encoded = "%" HEXDIG HEXDIG
 */
 
-// ------------------------------------ host    :port
-var portRegex = regexp.MustCompile(`(.*?)(?::(\d*))?$`)
-
 // Authority represents host, port and userinfo (user/pass) in a URI
 type Authority struct {
-	userinfo UserInfo
-	host     string
-	port     uint16
-	url      *url.URL
+	host string
+	port uint16
+	url  *url.URL
 }
 
 // UserInfo represents user/pass portion of a URI

utils/authority_test.go

@@ -24,7 +24,7 @@ type authorityTest struct {
 }
 
 func (a *authoritySuite) TestAuthority() {
-	tests := []authorityTest{
+	tests := []*authorityTest{
 		{
 			authorityString: "",
 			host:            "",