Fixed #152 bug where s3 backend failed to read empty files #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyshu
commented
Jan 22, 2024
| @@ -535,26 +536,35 @@ func waitUntilFileExists(file vfs.File, retries int) error { | |||
|
|
|||
| func (f *File) getReader() (io.ReadCloser, error) { | |||
| if f.reader == nil { | |||
There was a problem hiding this comment.
GH does a poor job of showing that I just moved this down to be nested under 'else'. Basically, were checking the source size and return a noop readcloser if it's zero. Otherwize return the usual range-based s3 reader.
dustin-schnee
approved these changes
Jan 22, 2024
AnthonyRoss
approved these changes
Jan 22, 2024
dhondgepooja
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 backend errors when reading an empty file #152