Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #156 - Update os backend to use new io integration test suite #157

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

funkyshu
Copy link
Member

@funkyshu funkyshu commented Feb 1, 2024

No description provided.

@c2fo-cibot c2fo-cibot bot added the size/M Denotes a PR that changes 30-99 lines label Feb 1, 2024
backend/os/file.go Outdated Show resolved Hide resolved
@funkyshu
Copy link
Member Author

funkyshu commented Feb 1, 2024

This one will take a careful rollout. I'll probably make a candidate tag to test in our repos. The changes are very slight but the biggest change is enforcing that changes don't occur to a file until you Close() it. Clearly, that change has broken a lot of tests where other backends use os.File that I still need to fix.

@dustin-schnee dustin-schnee requested review from AnthonyRoss, dhondgepooja and grant-higgins-0 and removed request for katiehrenchir February 2, 2024 13:19
@c2fo-cibot c2fo-cibot bot added size/L Denotes a PR that changes 100-499 lines and removed size/M Denotes a PR that changes 30-99 lines labels Feb 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (02139cf) 71.51% compared to head (50522e8) 71.36%.

Files Patch % Lines
backend/os/file.go 67.64% 6 Missing and 5 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   71.51%   71.36%   -0.15%     
==========================================
  Files          40       40              
  Lines        4672     4700      +28     
==========================================
+ Hits         3341     3354      +13     
- Misses       1056     1066      +10     
- Partials      275      280       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@funkyshu funkyshu merged commit 9b69441 into master Feb 7, 2024
9 checks passed
@funkyshu funkyshu deleted the os_io_updates branch February 7, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants