Stream writes 146 #164
Merged
Stream writes 146 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to backend/s3/mocks. Updated all references to old S3API iface to new one.
… writing to tempfile in case of seek/read
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 72.41% 71.55% -0.86%
==========================================
Files 41 41
Lines 4727 4915 +188
==========================================
+ Hits 3423 3517 +94
- Misses 1035 1105 +70
- Partials 269 293 +24 ☔ View full report in Codecov by Sentry. |
dustin-schnee
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146 - Update S3 backend to comply with new io integration test suite. Update to no longer write to memory.