Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set file permissions after writing an SFTP file. Resol… #203

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

funkyshu
Copy link
Member

…ves #202.

@c2fo-cibot c2fo-cibot bot added the size/XXL Denotes a PR that changes 1000+ lines label Sep 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 28.75000% with 342 lines in your changes missing coverage. Please review.

Project coverage is 21.03%. Comparing base (8b7451b) to head (089b625).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/sftp/mocks/Client.go 25.52% 127 Missing and 16 partials ⚠️
backend/sftp/mocks/FileInfo.go 5.88% 92 Missing and 4 partials ⚠️
backend/sftp/mocks/ReadWriteSeekCloser.go 29.62% 80 Missing and 15 partials ⚠️
backend/sftp/file.go 84.61% 4 Missing and 2 partials ⚠️
utils/utils.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   21.71%   21.03%   -0.69%     
==========================================
  Files          59       61       +2     
  Lines       19301    20341    +1040     
==========================================
+ Hits         4192     4278      +86     
- Misses      14648    15565     +917     
- Partials      461      498      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

// restart timer once action is completed
f.fileSystem.connTimerStop()
defer f.fileSystem.connTimerStart()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplified timer here...technically unrelated to the actual changes

@funkyshu funkyshu merged commit a405c69 into main Sep 16, 2024
8 checks passed
@funkyshu funkyshu deleted the add_set_perms_to_SFTP_202 branch September 16, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants