Windows support #207
Open
Windows support #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBaulch
force-pushed
the
windows
branch
2 times, most recently
from
f31bdc1 to
4fc5fa9
Compare
funkyshu
requested changes
Nov 17, 2024
There was a problem hiding this comment.
This looks good to me. Just add a CHANGELOG.md entry.
Also can you add windows-latest to the test matrix at https://github.com/C2FO/vfs/blob/main/.github/workflows/go.yml#L17
NathanBaulch
force-pushed
the
windows
branch
from
c3d64eb to
9b52478
Compare
|
Unit tests all pass on my Windows 10 machine - I guess we have more work to do to get it running in GitHub actions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All unit tests now passing on Windows.