Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_core functions for using pydantic config validation #19

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

GeigerJ2
Copy link
Collaborator

No description provided.

Base automatically changed from integrate-pydantic to main October 15, 2024 15:26
@agoscinski agoscinski force-pushed the workgraph-from-pydantic branch 2 times, most recently from f6c86c2 to f11249d Compare October 16, 2024 14:13
@agoscinski agoscinski marked this pull request as ready for review October 16, 2024 14:13
@GeigerJ2
Copy link
Collaborator Author

GeigerJ2 commented Oct 16, 2024

@agoscinski, OK, now this is cleaned up and only contains the changes I did. Feel free to make another PR adding the required examples directory (had to include core.py here). Then, I'll go ahead and pydantic the shit out of the latter :D

@GeigerJ2 GeigerJ2 changed the title WIP: Bring code using pydantic for config validation up to PR#14 Add to_core functions for using pydantic for config validation Oct 16, 2024
@GeigerJ2 GeigerJ2 changed the title Add to_core functions for using pydantic for config validation Add to_core functions for using pydantic config validation Oct 16, 2024
Copy link
Collaborator

@agoscinski agoscinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an issue to not forget this #21

@GeigerJ2 GeigerJ2 merged commit 403087c into main Oct 17, 2024
3 checks passed
@GeigerJ2 GeigerJ2 deleted the workgraph-from-pydantic branch October 17, 2024 08:50
@agoscinski agoscinski mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants