Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualization based on pygraphviz (requires graphviz installed locally) #34

Closed
wants to merge 63 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
ec4390f
add: First version of new IR with dependency resolving
leclairm Nov 4, 2024
13491dd
ref: move input_arg_options to task definition
leclairm Nov 4, 2024
cbd2f59
fix: missing part in __setitem__
leclairm Nov 4, 2024
8209941
ref: some minor typing changes
leclairm Nov 4, 2024
8bd74a4
ref(core): add method redundant with __setitem__
leclairm Nov 4, 2024
a730750
fix: adapt small test yaml file
leclairm Nov 4, 2024
c1c36a5
add: first version of workflow string representation
leclairm Nov 4, 2024
d24627c
fix: allow referencing TimeSeries by absolute date
leclairm Nov 4, 2024
0688291
ref:add: generic TimeSeries type and refactor __str__ methods
leclairm Nov 4, 2024
6eb2f7c
add: serialized data
leclairm Nov 4, 2024
2612b6c
del: cleanup
leclairm Nov 4, 2024
4e302e0
fix: hatch fmt
leclairm Nov 4, 2024
1f67b84
fix: hatch fmt
leclairm Nov 4, 2024
55a9f50
fix: hatch fmt
leclairm Nov 4, 2024
1e10b0a
add: logging
leclairm Nov 5, 2024
9ed2793
fix: hatch fmt
leclairm Nov 5, 2024
0c148f6
add: visualization based on pygraphviz
leclairm Nov 5, 2024
910eefc
fix: hatch fmt
leclairm Nov 5, 2024
1167d7e
fix: hatch fmt
leclairm Nov 5, 2024
68ebef4
add: green nodes for available data
leclairm Nov 5, 2024
549f7bc
del: remove buttons
leclairm Nov 5, 2024
3f3cbc4
ref:add: tooltips for nodes, color calculation
leclairm Nov 6, 2024
2c93ff0
fix: hatch fmt
leclairm Nov 6, 2024
adf1634
ref: string handling
leclairm Nov 7, 2024
22b9e0f
fix: check if TImeSeries initialized before testing dates
leclairm Nov 7, 2024
69a326d
fix: revert of test order again.
leclairm Nov 7, 2024
ce6fa8e
ref: use dataclass for Task as well
leclairm Nov 7, 2024
eb2b0ff
hatch fmt
leclairm Nov 7, 2024
6c877bc
ref: move resolve_dates from parsing to core
leclairm Nov 7, 2024
2868b0e
fix: remove also from parsing ...
leclairm Nov 7, 2024
48bb377
ref: move cycle date iterator from parsing to core
leclairm Nov 7, 2024
828af69
fix: hatch fmt
leclairm Nov 7, 2024
00d3032
ref: put underscore back even if ruff complains
leclairm Nov 8, 2024
37bd52f
add: test for serialized workflow IR graph
leclairm Nov 8, 2024
a6391b5
ref: not only atmospheric science!
leclairm Nov 8, 2024
8f65011
add:test: test against serialized data
leclairm Nov 8, 2024
7967fc3
fix: Climate Science classifier does not exist
leclairm Nov 8, 2024
b6daca8
ref: remove _ from DataBaseModel, used outside
leclairm Nov 8, 2024
dbba6fc
fix: hatch fmt
leclairm Nov 8, 2024
d098fe3
ref: _resolve_target_dates is a staticmethod
leclairm Nov 8, 2024
c418973
Merge branch 'IR_graph' into vizgraph
leclairm Nov 8, 2024
5b5a7e2
fix:test: invalid suffix
leclairm Nov 8, 2024
cf114a4
Merge branch 'IR_graph' into vizgraph
leclairm Nov 8, 2024
ae75d89
upd: serialized data
leclairm Nov 8, 2024
c9d5ce7
del: unused function
leclairm Nov 8, 2024
510585f
ref: move testing data to own directory
leclairm Nov 8, 2024
78fa026
ref: move testing data to its own directory
leclairm Nov 8, 2024
fd65e0e
Merge branch 'IR_graph' into vizgraph
leclairm Nov 8, 2024
ee023b6
fix: generate test data in the right directory
leclairm Nov 8, 2024
5ad966e
Merge branch 'IR_graph' into vizgraph
leclairm Nov 8, 2024
0dfc913
fix: regenerate testing data
leclairm Nov 8, 2024
c48ccd8
fix: bad merge conflict solving
leclairm Nov 8, 2024
453cb1b
fix: hatch fmt
leclairm Nov 8, 2024
406f1a5
fix: install graphviz for testing CI
leclairm Nov 8, 2024
40c1a3e
fix: use GH action for graphviz setup
leclairm Nov 8, 2024
5a39fa7
fix: try other GH action for graphviz
leclairm Nov 8, 2024
fe93c34
fix: another try for graphviz
leclairm Nov 8, 2024
da472e0
fix: graphviz for the 3 tests
leclairm Nov 8, 2024
593778f
fix: hatch fmt
leclairm Nov 8, 2024
8610895
Merge branch 'IR_graph' into vizgraph
leclairm Nov 8, 2024
b36d5e3
Merge branch 'main' into vizgraph
leclairm Nov 12, 2024
2fdd1f6
fix: workflow.name lost in merge conflict
leclairm Nov 12, 2024
72a6327
fix: replace tabs by spaces
leclairm Nov 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: check if TImeSeries initialized before testing dates
  • Loading branch information
leclairm committed Nov 7, 2024
commit 22b9e0fdb05bd223b704265f2bc80dcd625d4eff
9 changes: 6 additions & 3 deletions src/sirocco/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,16 +159,19 @@ def __setitem__(self, date: datetime, data: TimeSeriesObject) -> None:
self.end_date = date

def __getitem__(self, date: datetime) -> TimeSeriesObject:
if self.start_date is None:
msg = "TimeSeries still empty, cannot access by date"
raise ValueError(msg)
if date not in self._dict:
msg = f"date {date} not found"
raise KeyError(msg)
if date < self.start_date or date > self.end_date:
item = next(iter(self._dict.values()))
msg = (
f"date {date} for item '{item.name}' is out of bounds [{self.start_date} - {self.end_date}], ignoring."
)
logger.warning(msg)
return None
if date not in self._dict:
msg = f"date {date} not found"
raise KeyError(msg)
return self._dict[date]

def values(self) -> Iterator[TimeSeriesObject]:
Expand Down
Loading